- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.3k
 
Swimlane fixes and e2e tests for #8138 #8150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- timeline-holder now set to 100% height. - c-swimlane now space-fills available vertical space, and provides overflow scroll.
- resize is not yet persisted
- WIP! - Moved many CSS defs from flexible-layout.scss into new mixin `resizeHandleStyle`. - Fixed bad `drap-orientation` arg in TimelineViewLayout.vue. - Styling for resize handles in Time Strip view.
- Repair broken Plan/Gantt view when not in Time Strip.
- Column resizing now shows the horizontal resize handle on the Time axis swimlane only. Handle now uses `:height` from the extended overlay lines to extend across all swimlanes. - TODO: fix regressions in Plan/Gantt view affecting swimlane height and overflow handling.
- Reduced opacity of extended event lines and the Marcus-Baines line to not obfuscate telemetry and other data displayed in the Time Strip. - Removed commented CSS code.
- Reduced opacity of extended event lines and the Marcus-Baines line to not obfuscate telemetry and other data displayed in the Time Strip. - Removed commented CSS code. - WIP!
allow for fixed containers WIP move existing functionality into setup
- Now normalizes margin so that main-container does not change size between browse and edit modes. - Fixed long-standing regression where extra space was added for the toolbar when editing, even if view does not use a toolbar.
… Strip view. - TimelineViewLayout.vue now adds `is-object-type-*` to its container to allow CSS selection. - Object's `c-object-view` handles overflow-y with scroll when in Time Strip. This is necessary to prevent scrolling of the left hand labels and maintain a consistent right edge alignment for time sync purposes. - Fixed long-standing regression where extra space was added for the toolbar when editing, even if view does not use a toolbar. - Main view now uses dashed border instead of box-shadow for `.is-editing`; theme constants removed.
add swimLaneLabelWidth input to inspector
fix sizing logic
This reverts commit 6f38ca9 and removes commented code.
fixes inspector e2e
- Remove incorrect explicit height being applied to each extended overlay line. - Rename and set overlay lines container to be `display: contents`.
* default size 200px * resize using drag and drop * resize using inspector elements tab entry
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##           master    #8150      +/-   ##
==========================================
- Coverage   57.12%   56.87%   -0.26%     
==========================================
  Files         692      700       +8     
  Lines       27890    28149     +259     
  Branches     2741     2748       +7     
==========================================
+ Hits        15933    16010      +77     
- Misses      11619    11798     +179     
- Partials      338      341       +3     
 
 ... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
Closes #8005, follow up to #8138
Describe your changes:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist